-
Notifications
You must be signed in to change notification settings - Fork 63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update vendored ndimage code with axes support #813
base: branch-25.02
Are you sure you want to change the base?
Update vendored ndimage code with axes support #813
Conversation
* fix axes support in _rank_filter so all CuPy test cases pass for it
…place, generic_laplace, gaussian_gradient_magnitude
after this update all tests under cupyx.scipy.ndimage test suite pass when monkey-patching them to use the vendored ndimage module from cuCIM
behavior does not match elementwise kernel in this edge case
b74d3d6
to
af2fce4
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @grlee77 for this update!
I have a minor comment/question about the check_axes()
method. Other than that, it looks good to me!
Co-authored-by: Gigon Bae <[email protected]>
CI failure was an unrelated SHA256 checksum error from
It is rerunning now after accepting Gigon's suggestion, so hopefully that will resolve itself. |
I contributed user-specified
axes
support to the scipy.ndimage API (for filtering and morphology functions). SciPy 0.15 is the first public release with these changes.I originally developed this GPU port of the code in a local cuCIM branch, but submitted it upstream to CuPy and got it merged there before opening this MR. See cupy/cupy#8858 (will first appear in CuPy 14.0).
The test cases here were created before I created the CuPy MR and were later updated/integrated into CuPy's existing style in the MR there. I think we may as well keep the extra tests here as a sanity check that the vendored code continues to work as expected.
Additional testing
A few miscellaneous other updates were copied over from CuPy so that the full
cupyx.scipy.ndimage
test suite patches with the vendored ndimage from cuCIM when applying the following patch to CuPy's test suite (monkey-patches the module to use the one from cuCIM)