-
Notifications
You must be signed in to change notification settings - Fork 932
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add pylibcudf.gpumemoryview
support for len()
/nbytes
#18133
base: branch-25.04
Are you sure you want to change the base?
Add pylibcudf.gpumemoryview
support for len()
/nbytes
#18133
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @pentschev, can you update the type stub? https://github.com/rapidsai/cudf/blob/branch-25.04/python/pylibcudf/pylibcudf/gpumemoryview.pyi
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I definitely prefer this over rapidsai/rapids-dask-dependency#89
|
Agreed, closed that in favor of the change in this PR. |
Description
Add support for
len()
andnbytes
inpylibcudf.gpumemoryview
. Having those methods is helpful to ensure proper serialization in Dask/Distributed, as utility methods that serialize objects, in this case used by cudf-polars, may use the appropriate method or property to determine the size of the object being transferred.Checklist