Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Forward-merge branch-25.02 into branch-25.04 #18140

Merged
1 commit merged into from
Mar 3, 2025
Merged

Forward-merge branch-25.02 into branch-25.04 #18140

1 commit merged into from
Mar 3, 2025

Conversation

rapids-bot[bot]
Copy link

@rapids-bot rapids-bot bot commented Mar 1, 2025

Forward-merge triggered by push to branch-25.02 that creates a PR to keep branch-25.04 up-to-date. If this PR is unable to be immediately merged due to conflicts, it will remain open for the team to manually merge. See forward-merger docs for more info.

@vyasr
Use protocol for dlpack instead of deprecated function (#18134)
09ebf31 
This PR adapts cudf's dlpack tests for compatibility with cupy 13.4,
which was just released yesterday on PyPI and containers
cupy/cupy#8722 that breaks the legacy toDlpack
functionality.
@rapids-bot rapids-bot bot requested a review from a team as a code owner March 1, 2025 00:36
@rapids-bot rapids-bot bot requested review from wence- and mroeschke March 1, 2025 00:36
@rapids-bot rapids-bot
Copy link
Author

rapids-bot bot commented Mar 1, 2025

FAILURE - Unable to forward-merge due to an error, manual merge is necessary. Do not use the Resolve conflicts option in this PR, follow these instructions https://docs.rapids.ai/maintainers/forward-merger/

IMPORTANT: When merging this PR, do not use the auto-merger (i.e. the /merge comment). Instead, an admin must manually merge by changing the merging strategy to Create a Merge Commit. Otherwise, history will be lost and the branches become incompatible.

@github-actions github-actions bot added the Python Affects Python cuDF API. label Mar 1, 2025
@vyasr vyasr mentioned this pull request Mar 1, 2025
Merged
3 tasks
@codecov Codecov
Copy link

codecov bot commented Mar 1, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 50.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 86.00%. Comparing base (1fe744f) to head (09ebf31).
Report is 173 commits behind head on branch-25.04.

Files with missing lines Patch % Lines
python/cudf/cudf/core/subword_tokenizer.py 0.00% 1 Missing ⚠️
Additional details and impacted files 
@@              Coverage Diff              @@
##           branch-25.04   #18140   +/-   ##
=============================================
  Coverage         85.99%   86.00%           
=============================================
  Files               226      226           
  Lines             33498    33498           
=============================================
+ Hits              28808    28811    +3     
+ Misses             4690     4687    -3

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@raydouglass raydouglass closed this pull request by merging all changes into branch-25.04 in fbbd69d Mar 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wence- wence- Awaiting requested review from wence- wence- is a code owner automatically assigned from rapidsai/cudf-python-codeowners

@mroeschke mroeschke Awaiting requested review from mroeschke mroeschke is a code owner automatically assigned from rapidsai/cudf-python-codeowners

Assignees
No one assigned
Labels
Python Affects Python cuDF API.
Projects
cuDF Python
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@raydouglass @vyasr