Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: Install pytest-env and hypothesis in test_narwhals.sh #18337

Merged
merged 3 commits into from
Mar 26, 2025

Conversation

MarcoGorelli
Copy link
Contributor

Update test_narwhals.sh to install pytest-env and hypothesis

In Narwhals these are pulled in by using --group test, but that requires uv (which cuDF doesn't use)

Demo of this working: https://www.kaggle.com/code/marcogorelli/narwhals-pre-release-test-cudf/notebook?scriptVersionId=228712396

Description

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

Update `test_narwhals.sh` to install pytest-env and hypothesis

In Narwhals these are pulled in by using `--group test`, but that requires uv (which cuDF doesn't use)
@MarcoGorelli MarcoGorelli requested a review from a team as a code owner March 20, 2025 16:17
@MarcoGorelli MarcoGorelli requested a review from bdice March 20, 2025 16:17
Copy link

copy-pr-bot bot commented Mar 20, 2025

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@MarcoGorelli MarcoGorelli marked this pull request as draft March 20, 2025 16:17
@MarcoGorelli MarcoGorelli changed the title Install pytest-env and hypothesis in test_narwhals.sh test: Install pytest-env and hypothesis in test_narwhals.sh Mar 20, 2025
@MarcoGorelli MarcoGorelli marked this pull request as ready for review March 20, 2025 16:19
@mroeschke
Copy link
Contributor

I do see these dependencies already being downloaded in our test_narwhals.sh job e.g https://github.com/rapidsai/cudf/actions/runs/13956935763/job/39071672911?pr=18331

Requirement already satisfied: hypothesis in /opt/conda/envs/test/lib/python3.12/site-packages (from narwhals==1.31.0) (6.129.3)
...
Collecting pytest-env (from narwhals==1.31.0)
  Downloading pytest_env-1.1.5-py3-none-any.whl.metadata (5.2 kB)

And they are specified in your dependency group too (on the stable branch)

https://github.com/narwhals-dev/narwhals/blob/668bbf698e5dee67576b9a003144d03f15b65310/pyproject.toml#L46-L47

Is this going to change instead?

@MarcoGorelli
Copy link
Contributor Author

And they are specified in your dependency group too (on the stable branch)

Yes but this PR changed it on main: narwhals-dev/narwhals#2238

Adding pytest-env and hypothesis in here is technically redundant, but future proofs your CI for when we'll make the next release (which happens every Monday, so in not too long)

@mroeschke
Copy link
Contributor

Ah I see thanks.

Just FYI, we are also thinking of starting to test off Narwhals tags instead of the stable branch to mirror what we do for the pandas tests #18191, but this will still be useful if/when we start pinning to the tag where this changes

Co-authored-by: Edoardo Abati <[email protected]>
@mroeschke
Copy link
Contributor

Ok thanks could you target this PR to the branch-25.06 branch instead? RAPIDS is in the process of releasing soon as well

@MarcoGorelli MarcoGorelli changed the base branch from branch-25.04 to branch-25.06 March 21, 2025 20:11
@MarcoGorelli
Copy link
Contributor Author

done, thanks!

@MarcoGorelli
Copy link
Contributor Author

MarcoGorelli commented Mar 24, 2025

@mroeschke gentle ping (else CI won't be green 🥦 , we're releasing today)

@mroeschke mroeschke added improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Mar 24, 2025
@mroeschke
Copy link
Contributor

/ok to test

@vyasr vyasr changed the base branch from branch-25.06 to branch-25.04 March 25, 2025 18:20
@vyasr
Copy link
Contributor

vyasr commented Mar 25, 2025

/ok to test

@raydouglass raydouglass merged commit 2d8f188 into rapidsai:branch-25.04 Mar 26, 2025
111 of 112 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement Improvement / enhancement to an existing function non-breaking Non-breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants