-
Notifications
You must be signed in to change notification settings - Fork 942
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: Install pytest-env and hypothesis in test_narwhals.sh #18337
Conversation
Update `test_narwhals.sh` to install pytest-env and hypothesis In Narwhals these are pulled in by using `--group test`, but that requires uv (which cuDF doesn't use)
I do see these dependencies already being downloaded in our Requirement already satisfied: hypothesis in /opt/conda/envs/test/lib/python3.12/site-packages (from narwhals==1.31.0) (6.129.3)
...
Collecting pytest-env (from narwhals==1.31.0)
Downloading pytest_env-1.1.5-py3-none-any.whl.metadata (5.2 kB) And they are specified in your dependency group too (on the stable branch) Is this going to change instead? |
Yes but this PR changed it on Adding |
Ah I see thanks. Just FYI, we are also thinking of starting to test off Narwhals tags instead of the |
Co-authored-by: Edoardo Abati <[email protected]>
Ok thanks could you target this PR to the |
done, thanks! |
@mroeschke gentle ping (else CI won't be green 🥦 , we're releasing today) |
/ok to test |
/ok to test |
Update
test_narwhals.sh
to install pytest-env and hypothesisIn Narwhals these are pulled in by using
--group test
, but that requires uv (which cuDF doesn't use)Demo of this working: https://www.kaggle.com/code/marcogorelli/narwhals-pre-release-test-cudf/notebook?scriptVersionId=228712396
Description
Checklist