Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automatically dispatch between host and device decompression/compression based on the number of buffers #18363

Open
wants to merge 9 commits into
base: branch-25.06
Choose a base branch
from

Conversation

vuule
Copy link
Contributor

@vuule vuule commented Mar 25, 2025

Description

Issue: #17641

Add support for dynamically using host decompression/compression over the kernel implementation, where the host option is used when the number of buffer is below a certain threshold. This dynamic dispatch is enabled separately for decompression and compression by setting LIBCUDF_HOST_DECOMPRESSION or LIBCUDF_HOST_COMPRESSION to "AUTO".
The threshold is based on limited testing. Users can also set the threshold via LIBCUDF_HOST_DECOMPRESSION_THRESHOLD and LIBCUDF_HOST_COMPRESSION_THRESHOLD.

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

Copy link

copy-pr-bot bot commented Mar 25, 2025

Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually.

Contributors can view more details about this message here.

@github-actions github-actions bot added the libcudf Affects libcudf (C++/CUDA) code. label Mar 25, 2025
@vuule vuule added feature request New feature or request non-breaking Non-breaking change labels Mar 25, 2025
@vuule vuule marked this pull request as ready for review March 31, 2025 19:01
@vuule vuule requested a review from a team as a code owner March 31, 2025 19:01
@vuule vuule requested review from lamarrr and nvdbaranec March 31, 2025 19:01
@vuule
Copy link
Contributor Author

vuule commented Mar 31, 2025

Did not add tests because the impact is really only on the implementation, should have no observable change in behavior. Host compression/decompression is already tested.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request New feature or request libcudf Affects libcudf (C++/CUDA) code. non-breaking Non-breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant