Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Silence warning by setting BUILD_SHARED_LIBS #18371

Open
wants to merge 1 commit into
base: branch-25.06
Choose a base branch
from
Open

Silence warning by setting BUILD_SHARED_LIBS #18371

wants to merge 1 commit into from

Conversation

vyasr
Copy link
Contributor

@vyasr vyasr commented Mar 25, 2025

Description

zstd warns (but behaves as expected) if BUILD_SHARED_LIBS conflicts with the zstd-specific CMake options. This change silences that warning.

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@vyasr vyasr added improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Mar 25, 2025
@vyasr vyasr self-assigned this Mar 25, 2025
@vyasr vyasr requested a review from a team as a code owner March 25, 2025 18:43
@github-actions github-actions bot added libcudf Affects libcudf (C++/CUDA) code. CMake CMake build issue labels Mar 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@vyasr vyasr

Labels
CMake CMake build issue improvement Improvement / enhancement to an existing function libcudf Affects libcudf (C++/CUDA) code. non-breaking Non-breaking change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@vyasr