Create Conda CI test env in one step #4935
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KyleFromNVIDIA
added
improvement
19 tasks
jameslamb
requested changes
Feb 13, 2025
There was a problem hiding this comment.
This needs some changes.
Also, build failures like this:
/pyenv/versions/3.12.9/lib/python3.12/site-packages/libraft/include/raft/spectral/detail/partition.hpp(107): error: no suitable user-defined conversion from "raft::spectral::matrix::detail::laplacian_matrix_t<int32_t, float, uint64_t>" to "const raft::spectral::matrix::detail::sparse_matrix_t<int32_t, float, int32_t>" exists
detected during:
instantiation of "std::tuple<vertex_t, weight_t, vertex_t> raft::spectral::detail::partition(const raft::resources &, const raft::spectral::matrix::detail::sparse_matrix_t<vertex_t, weight_t, nnz_t> &, const EigenSolver &, const ClusterSolver &, vertex_t *, weight_t *, weight_t *) [with vertex_t=int32_t, weight_t=float, nnz_t=uint64_t, EigenSolver=raft::spectral::lanczos_solver_t<int32_t, float, int32_t>, ClusterSolver=raft::spectral::kmeans_solver_t<int32_t, float, int32_t>]"
/pyenv/versions/3.12.9/lib/python3.12/site-packages/libraft/include/raft/spectral/partition.cuh(63): here
Should be fixed by #4934
ChuckHastings
approved these changes
Feb 18, 2025
jameslamb
approved these changes
Feb 20, 2025
|
/merge |
rapids-bot bot
pushed a commit
that referenced
this pull request
Feb 21, 2025
Follow up to #4935 There, in #4935 (comment), we discussed the that GNN packages shouldn't need to be installed in docs builds any more, as no docs in this repo (including notebooks) require them. This PR limits dependencies on the GNN packages to only the places they're needed. ### `libwholegraph` / `pylibwholegraph` ```shell git grep -i -E 'wholegraph' ``` Optional runtime dependency of `cugraph`: https://github.com/rapidsai/cugraph/blob/2873ff91945c4944568ffd1aa035f6bba17746a0/python/cugraph/cugraph/gnn/feature_storage/feat_storage.py#L23 And optional test-time dependency of `cugraph`: https://github.com/rapidsai/cugraph/blob/2873ff91945c4944568ffd1aa035f6bba17746a0/python/cugraph/cugraph/tests/data_store/test_gnn_feat_storage_wholegraph.py#L24-L25 But not used in any docs. **Changes:** Removed from `docs` environment. ### `cugraph-dgl` ```shell git grep -i -E 'cugraph.*dgl' ``` Not used anywhere in this repo. **Changes:** Removed all remaining references. ### `cugraph-pyg` ```shell git grep -i -E 'cugraph.*pyg' ``` Only used as an optional import in `cugraph-service-client`'s tests (which are not run in CI for wheels). https://github.com/rapidsai/cugraph/blob/2873ff91945c4944568ffd1aa035f6bba17746a0/python/cugraph-service/tests/test_remote_graph.py#L662 **Changes:** Removed from the `docs` environment, added a `[test]` extra to `cugraph-service-client` including this. ## Notes for Reviewers Related to these issues about moving more GNN stuff out of this repo: * #4822 * #4407 Authors: - James Lamb (https://github.com/jameslamb) Approvers: - Chuck Hastings (https://github.com/ChuckHastings) - Mike Sarahan (https://github.com/msarahan) - Bradley Dice (https://github.com/bdice) URL: #4947
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: rapidsai/build-planning#22