Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add shellcheck to pre-commit and fix warnings #772

Merged
merged 1 commit into from
Feb 10, 2025

Conversation

gforsyth
Copy link
Contributor

Description

shellcheck is a fast, static analysis tool for shell scripts. It's good at
flagging up unused variables, unintentional glob expansions, and other potential
execution and security headaches that arise from the wonders of bash (and
other shlangs).

This PR adds a pre-commit hook to run shellcheck on all of the sh-lang
files in the ci/ directory, and the changes requested by shellcheck to make
the existing files pass the check.

xref: rapidsai/build-planning#135

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.
  • The cmake-format.json is up to date with these changes.
  • I have added new files under rapids-cmake/
    • I have added include guards (include_guard(GLOBAL))
    • I have added the associated docs/ rst file and update the api.rst

@gforsyth gforsyth requested a review from a team as a code owner February 10, 2025 19:19
@gforsyth gforsyth added improvement Improves an existing functionality non-breaking Introduces a non-breaking change labels Feb 10, 2025
@gforsyth gforsyth requested a review from a team as a code owner February 10, 2025 19:19
@gforsyth gforsyth requested review from KyleFromNVIDIA and removed request for a team February 10, 2025 19:19
@vyasr
Copy link
Contributor

vyasr commented Feb 10, 2025

/merge

@rapids-bot rapids-bot bot merged commit d3d9a6b into rapidsai:branch-25.04 Feb 10, 2025
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement Improves an existing functionality non-breaking Introduces a non-breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants