add telemetry #1116
Merged
add telemetry #1116
+26
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jameslamb
reviewed
Feb 7, 2025
jameslamb
approved these changes
Feb 7, 2025
There was a problem hiding this comment.
Looks good to me! I looked through the logs of telemetry-setup and telemetry-summarize, didn't see any obvious issues.
And I saw the check statuses as ✅ and no other issues reported in the build summary.
I fixed merge conflicts caused by #1117 which was just merged, please double-check the diff and make sure I didn't mess anything up before merging this.
|
/merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enables telemetry during CI runs. This is done by parsing GitHub Actions run log metadata and should have no impact on build or test times.
xref https://github.com/rapidsai/build-infra/issues/139