Skip to content

Add thread multiplier configurations to worker/config_native.properties #218

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
karthikeyann wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Add thread multiplier configurations to worker/config_native.properties #218

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 27 additions & 0 deletions presto/docker/config/template/etc_worker/config_native.properties
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,33 @@ system-mem-pushback-enabled=true
system-mem-limit-gb={{ sub .ContainerMemoryGb .GeneratorParameters.MemoryPushBackStartBelowLimitGb }}
system-mem-shrink-gb=20

# Each multiplier value affects number of threads used for each module.
# hw_concurrency x multiplier.
# 1.0 is default for each multiplier config.
Copy link

Copilot AI Feb 6, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The comment says "1.0 is default for each multiplier config", but later comments list different defaults (e.g., connector defaults to 0.0, driver to 4.0, spiller to 1.0). Please correct this line to reflect that defaults vary per setting (or update the per-setting default comments to match reality).

Suggested change
# 1.0 is default for each multiplier config.
# Default values differ per multiplier; see per-setting comments below.

Copilot uses AI. Check for mistakes.
# Number of threads for HTTP IO executor
http-server.num-io-threads-hw-multiplier=0.01
# Number of threads for HTTP CPU executor
http-server.num-cpu-threads-hw-multiplier=0.01
# Number of threads for CPU executor for connectors mainly for async operators
# If 0.0 then connector CPU executor would not be created.
# 0.0 is default.
#connector.num-cpu-threads-hw-multiplier=0.0
# Number of threads for IO executor for connectors mainly to do preload/prefetch:
# If 0.0 then connector preload/prefetch is disabled.
# 0.0 is default.
connector.num-io-threads-hw-multiplier=0.01
# Number of threeads for Driver CPU executor
Copy link

Copilot AI Feb 6, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Typo in comment: "threeads" should be "threads".

Suggested change
# Number of threeads for Driver CPU executor
# Number of threads for Driver CPU executor

Copilot uses AI. Check for mistakes.
# 4.0 is default. 4*nproc threads.
#driver.num-cpu-threads-hw-multiplier
# Number of threads for Spiller CPU executor
# If 0.0 then spilling is disabled.
# 1.0 is default.
#spiller.num-cpu-threads-hw-multiplier
Comment on lines +48 to +52
Copy link

Copilot AI Feb 6, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The commented-out examples for driver/spiller multipliers omit an '=' and example/default value (unlike the connector example above). This makes it harder to discover the intended configuration value and increases the chance of misconfiguration; consider adding the explicit default/example values (e.g., "...=4.0" / "...=1.0") or otherwise standardizing how these properties are documented.

Suggested change
#driver.num-cpu-threads-hw-multiplier
# Number of threads for Spiller CPU executor
# If 0.0 then spilling is disabled.
# 1.0 is default.
#spiller.num-cpu-threads-hw-multiplier
#driver.num-cpu-threads-hw-multiplier=4.0
# Number of threads for Spiller CPU executor
# If 0.0 then spilling is disabled.
# 1.0 is default.
#spiller.num-cpu-threads-hw-multiplier=1.0

Copilot uses AI. Check for mistakes.
# Number of threads for Exchange HTTP client CPU executor
exchange.http-client.num-cpu-threads-hw-multiplier=0.01
# Number of threads for Exchange HTTP client IO executor
exchange.http-client.num-io-threads-hw-multiplier=0.01

# Optimize for single-node execution when the entire query can run locally.
single-node-execution-enabled=true

Expand Down