Skip to content

Update tpc-h data generation #296

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
TomAugspurger wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Update tpc-h data generation #296

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions .github/workflows/velox-benchmark.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -95,10 +95,10 @@ jobs:
source .venv/bin/activate
pip install -q -r benchmark_data_tools/requirements.txt
python benchmark_data_tools/generate_data_files.py \
--benchmark-type tpch \
--data-dir-path "${TPCH_DATA_DIR}" \
--scale-factor 0.01 \
--convert-decimals-to-floats
Comment on lines -98 to -101
Copy link
Copy Markdown
Contributor

@paul-aiyedun paul-aiyedun Apr 1, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should be able to keep the existing script interface while changing the underlying data generator.

Copy link
Copy Markdown
Contributor Author

@TomAugspurger TomAugspurger Apr 2, 2026 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is that a goal, and if so do you have time to handle that?

We have some scripts relying on the interface from https://github.com/TomAugspurger/tpchgen-rs/tree/tom/sync-upstream-clean. We can update those, but that'll take time.

tpch \
--output "${TPCH_DATA_DIR}" \
--scale 0.01 \
--use-float-type

- name: Run TPC-H GPU benchmarks
env:
Expand Down
Loading
Loading