fix(ci): Re-enable velox_table_evolution_fuzzer_test in CPU builds#309
fix(ci): Re-enable velox_table_evolution_fuzzer_test in CPU builds#309
Conversation
mattgara
left a comment
There was a problem hiding this comment.
LGTM, is there a passing example run with this enabled?
|
We can test this part officially once the fix lands. |
|
But this script |
Oops! OK... what runs tests now then? Does it need an equivalent change. Would look but on my phone and too lazy to fire up the computer... |
|
The CPU test command is here: velox-testing/.github/workflows/velox-test.yml Lines 87 to 88 in 0f2e363 If we are supposed to use a common/shared test script, that's fine with me as long as we can call it through Docker with a custom image like the current GitHub Actions setup. |
If the new YAML implementation does the job, I don't see a need to change it. Presumably this is how we were reminded that the If that's now the definitive method, should we remove the |
Once facebookincubator/velox#17106 lands, this test can once more be safely run in CI.