Skip to content

Vue compatibility fix x-cloak #2243

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: development
Choose a base branch
from

Conversation

kvovadis
Copy link

@kvovadis kvovadis commented Apr 20, 2025

Update TableAttributeHelpers.php

All Submissions:

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?

New Feature Submissions:

  1. Does your submission pass tests and did you add any new tests needed for your feature?
  2. Did you update all templates (if applicable)?
  3. Did you add the relevant documentation (if applicable)?
  4. Did you test locally to make sure your feature works as intended?

Changes to Core Features:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your core changes, as applicable?
  • Have you successfully ran tests with your changes locally?

lrljoe and others added 3 commits February 28, 2025 22:44
* Link column fix (rappasoft#2223)

* Add handling for From field for "LinkColumn"

* Update ChangeLog
Update TableAttributeHelpers.php
@lrljoe
Copy link
Collaborator

lrljoe commented Apr 20, 2025

Please only work from the "development" branch, and PRs should target the "development" branch.

@lrljoe lrljoe changed the base branch from master to development April 22, 2025 02:07
Copy link

codecov bot commented Apr 22, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.96%. Comparing base (0036a9a) to head (fe92984).
Report is 36 commits behind head on development.

Additional details and impacted files
@@                Coverage Diff                @@
##             development    #2243      +/-   ##
=================================================
+ Coverage          89.94%   89.96%   +0.02%     
- Complexity          2149     2154       +5     
=================================================
  Files                242      242              
  Lines               4851     4853       +2     
=================================================
+ Hits                4363     4366       +3     
+ Misses               488      487       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@lrljoe
Copy link
Collaborator

lrljoe commented May 3, 2025

@kvovadis - please don't use the "master" branch for development. I'm happy to merge this in, should you use a "non-master" branch for a PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants