Simplify standaline BT examples #667
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Move client and server to their own folder Get rid of the wifi stuff
|
vscode seems to have problems importing these examples - simplify them to make it easier |
will-v-pi
reviewed
Jul 16, 2025
Comment on lines
+14
to
+16
| target_include_directories(picow_ble_temp_reader PRIVATE | ||
| ${CMAKE_CURRENT_LIST_DIR}/.. # For btstack config | ||
| ) |
There was a problem hiding this comment.
Note that this will actually make it harder for VS Code to import, due to dependence on files out of the directory - could this be changed to something similar to how the wifi examples have a local lwipopts.h which just includes a common lwipopts_examples_common.h, so then VS Code can copy a standard file across (like it currently does for lwipopts)?
Suggested change
| target_include_directories(picow_ble_temp_reader PRIVATE | |
| ${CMAKE_CURRENT_LIST_DIR}/.. # For btstack config | |
| ) | |
| target_include_directories(picow_ble_temp_reader PRIVATE | |
| ${CMAKE_CURRENT_LIST_DIR} | |
| ${CMAKE_CURRENT_LIST_DIR}/.. # For common btstack config | |
| ) |
There was a problem hiding this comment.
yes - will do
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move client and server to their own folder
Get rid of the wifi stuff