Merge pull request #42 from ravage84/drop-red-slip-support

Drop Red Slip Support
ravage84 · Feb 27, 2019 · 3f5e235 · 3f5e235
2 parents f0cec08 + c622948
commit 3f5e235
Show file tree

Hide file tree

Showing 13 changed files with 31 additions and 1,542 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -7,6 +7,7 @@ This project adheres to [Semantic Versioning](http://semver.org/).
 
 ### Changed
 - Add PHP 7.2 by name in Travis as PHP nightly seems to be PHP 7.3-dev
+- Removed unfinished support for Red Payment Slip (ES)
 
 ### Fixed
 

diff --git a/README.md b/README.md
@@ -12,7 +12,9 @@ Do you need to create Swiss payment slips (called ES or ESR) as PDF files in a p
 Then you found almost the right place, go to [SwissPaymentSlipFpdf](https://github.com/ravage84/SwissPaymentSlipFpdf)
 or [SwissPaymentSlipTcpdf](https://github.com/ravage84/SwissPaymentSlipTcpdf).
 
-If you need to include some basic logic for Swiss payment slips iny our PHP code base then you are probably right though...
+If you need to include some basic logic for Swiss payment slips in your PHP code base then you are probably right though...
+
+The partial and unfinished support for the red payment slip was dropped in version 0.13.0 due to lack of demand. 
 
 How to use
 ----------
@@ -60,9 +62,8 @@ I decided myself for the latter.
 TODOs
 -----
 
-- Finish support for red inpayment slips
 - Improve code documentation
-- Add more examples/improve existing ones
+- Add more examples/improve existing ones, showcase disabling the various field blocks better
 - Improve the tests
 - Release the stable release of the API
 
@@ -75,7 +76,7 @@ Author
 ------
 
 This project was created by [Marc Würth](https://github.com/ravage84).
-See Background Story for more details.
+See [Background Story](#background-story) for more details.
 
 License
 -------

diff --git a/composer.json b/composer.json
@@ -1,14 +1,13 @@
 {
     "name": "swiss-payment-slip/swiss-payment-slip",
-    "description": "A library for creating Swiss payment slips",
+    "description": "A library for creating Swiss payment slips (ESR)",
     "license": "MIT",
     "homepage": "https://github.com/ravage84/SwissPaymentSlip",
     "keywords": [
         "Payment slip",
         "Inpayment slip",
         "Einzahlungsschein",
-        "ESR",
-        "ES"
+        "ESR"
     ],
     "require": {
         "php": ">=5.4.0"

diff --git a/composer.lock b/composer.lock
diff --git a/examples/RedPaymentSlipData_Basic_Usage.php b/examples/RedPaymentSlipData_Basic_Usage.php
diff --git a/examples/index.php b/examples/index.php
@@ -21,7 +21,6 @@
 <p>Learn how to use the SwissPaymentSlip classes wit the following examples:</p>
 <ul>
 	<li><a href="OrangePaymentSlipData_Basic_Usage.php">01-01 Basic Usage of OrangePaymentSlipData</a></li>
-	<li><a href="RedPaymentSlipData_Basic_Usage.php">01-01 Basic Usage of RedPaymentSlipData</a></li>
 	<li><a href="OrangePaymentSlipData_Advanced_Usage.php">01-03 Advanced Usage of OrangePaymentSlipData</a></li>
 	<li><a href="OrangePaymentSlip_Basic_Usage.php">02-01 Basic Usage of OrangePaymentSlip</a></li>
 </ul>

diff --git a/phpunit-html-coverage.xml b/phpunit-html-coverage.xml
@@ -8,10 +8,8 @@
             <file>./tests/Exception/DisabledDataExceptionTest.php</file>
             <file>./tests/PaymentSlipDataTest.php</file>
             <file>./tests/OrangePaymentSlipDataTest.php</file>
-            <file>./tests/RedPaymentSlipDataTest.php</file>
             <file>./tests/PaymentSlipTest.php</file>
             <file>./tests/OrangePaymentSlipTest.php</file>
-            <file>./tests/RedPaymentSlipTest.php</file>
         </testsuite>
     </testsuites>
     <filter>

diff --git a/phpunit.xml.dist b/phpunit.xml.dist
@@ -8,10 +8,8 @@
             <file>./tests/Exception/DisabledDataExceptionTest.php</file>
             <file>./tests/PaymentSlipDataTest.php</file>
             <file>./tests/OrangePaymentSlipDataTest.php</file>
-            <file>./tests/RedPaymentSlipDataTest.php</file>
             <file>./tests/PaymentSlipTest.php</file>
             <file>./tests/OrangePaymentSlipTest.php</file>
-            <file>./tests/RedPaymentSlipTest.php</file>
         </testsuite>
     </testsuites>
 </phpunit>