RDoc-1627 + RDoc-3295 Indexing Metadata + Indexing ALL fields for FTS #2014
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alxsabo
approved these changes
Apr 10, 2025
poissoncorp
reviewed
Apr 10, 2025
| {PANEL: Indexing all fields for FTS (using AsJson)} | ||
|
|
||
| * To search across ALL fields in a document without defining each one explicitly, use the `AsJson` method, | ||
| which is available in the **C# LINQ string** that is assigned to the `self.map` property in the Python index class, |
There was a problem hiding this comment.
self.map feels natural (self = this), but incorrect - map is the str property of index class
consider changing, but no need to do that
poissoncorp
approved these changes
Apr 10, 2025
…p' when referring to the property
M4xymm
approved these changes
Apr 14, 2025
Lwiel
approved these changes
Apr 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issues:
https://issues.hibernatingrhinos.com/issue/RDoc-1627/Access-to-internal-properties-of-a-document
https://issues.hibernatingrhinos.com/issue/RDoc-3295/Index-all-fields-for-FTS-using-AsJson
To be reviewed:
C# @Lwiel
Python @poissoncorp
PHP @alxsabo
Node.js @ml054 @M4xymm
Java:
As written in the related issues:
Need to open a new dedicated issue for Java to match text & examples to the C# articles.