Fix 4P/4D GLM NIAH: Wei combine() topk_ids and pair warmup with score - #4
Open
basemam wants to merge 1 commit into
Open
Conversation
EP32 was gathering with dispatched ids; NIAH now warms each length then scores it so a later EngineCore 500 cannot zero earlier sizes. Serve argv unchanged.
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
combine()patch (e25bf182): MoRIfinalize()uses originaltopk_ids, not dispatched ids. Required at EP32 (4P/4D). Runs even withGLM_SKIP_PATCHERS=1. Does not change P/Dvllm serveargv (FULL graphs, decodemnbt=2048, kv-config, Rustvllm-router).BENCHMARK_SCRIPT=niah, stillPOST /v1/chat/completions. Pairing is warmup N then score N (not warm-all-then-score-all).Result — job 217082 (4P/4D, GLM-5.1-FP8)
Image
rocmshared/pytorch-private:glm5.1-pr176-verify,GLM_SKIP_PATCHERS=1, Wei combine applied at serve, Rust router,NIAH_SEEDS=0,NIAH_HALT_ON_FAIL=0.Log:
/shared_inference/bbarakat/model_blog_logs/217082/niah_217082_20260818_195513_xP4_yD4_GLM-5.1-FP8.log