fix: Context messages incorrectly included in title generation#79
Open
nick-galluzzo wants to merge 1 commit into
Open
fix: Context messages incorrectly included in title generation#79nick-galluzzo wants to merge 1 commit into
nick-galluzzo wants to merge 1 commit into
Conversation
…sages tag and context id are stored in msg._meta.tag and msg.context.id by add_message(), not in msg.opts. This is causing context messaqges to pass the filter and pollute title generation.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Context messages added via
add_context()(rules files, attached files, buffers) were being included in title generation instead of filtered out. This caused every chat with injected context to produce a title based on that context rather than the user's actual question.For example, a user has a CLAUDE.md loaded for every chat and is 1000 characters or more, every title is generated with that information only, and disregards the user message.
Related Issue(s)
NA (found while debugging)
Screenshots
All 3 titles are from the same setup and same message:
Checklist
make testto ensure all tests passmake formatto format the codemake docsto update the vimdoc pages