[Kubectl-plugin] ray session --kill-all #3422
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Troy Chiu <[email protected]>
Signed-off-by: Troy Chiu <[email protected]>
Signed-off-by: Troy Chiu <[email protected]>
Signed-off-by: Troy Chiu <[email protected]>
Signed-off-by: Troy Chiu <[email protected]>
|
Better to use |
Signed-off-by: Troy Chiu <[email protected]>
troychiu
changed the title
|
Hi @MortalHappiness can I get a review from you? Thank you. |
Comment on lines
+120
to
+130
| if options.killAll { | ||
| if len(args) > 0 { | ||
| return cmdutil.UsageErrorf(cmd, "accepts no args when killAll flag is set") | ||
| } | ||
| return nil | ||
| } | ||
|
|
||
| if len(args) == 0 { | ||
| return cmdutil.UsageErrorf(cmd, "killAll flag is not set, but no args provided") | ||
| } | ||
|
|
There was a problem hiding this comment.
Create another function called Validate and put the validation log there. You can use other files for reference. The order is Complete, Validate, Run.
| @@ -216,3 +247,45 @@ func (options *SessionOptions) Run(ctx context.Context, factory cmdutil.Factory) | |||
| wg.Wait() | |||
| return nil | |||
| } | |||
|
|
|||
| func killAllRaySessions(ctx context.Context, verbose bool) error { | |||
There was a problem hiding this comment.
Could you add a test for this function?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
Reference #3232 (comment)
This PR adds an option
--kill-alltoray session, which kills all existingray session.Example:
$ kubectl ray session --kill-all -v killAll flag is set, killing all existing Ray sessions... Found ray session: /Users/troy/.krew/bin/kubectl-ray session -n test rayjob-sample-dj7p5 Killing subprocess with PID 39598 Killing process with PID 39597Related issue number
N/A
Checks