Skip to content

fix: ensure graceful shutdown for Ray head container when GCS fault tolerance is enabled #4079

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

fix: ensure graceful shutdown for Ray head container when GCS fault tolerance is enabled #4079

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 14 additions & 0 deletions ray-operator/controllers/ray/common/pod.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,6 +85,20 @@ func configureGCSFaultTolerance(podTemplate *corev1.PodTemplateSpec, instance ra
options := instance.Spec.GcsFaultToleranceOptions
container := &podTemplate.Spec.Containers[utils.RayContainerIndex]

// Configure lifecycle preStop hook for graceful shutdown when GCS FT is enabled
if rayNodeType == rayv1.HeadNode {
if container.Lifecycle == nil {
container.Lifecycle = &corev1.Lifecycle{}
}
if container.Lifecycle.PreStop == nil {
container.Lifecycle.PreStop = &corev1.LifecycleHandler{
Exec: &corev1.ExecAction{
Command: []string{"/bin/sh", "-c", "ray stop --force"},
},
}
}
}

// Configure the GCS RPC server reconnect timeout for GCS FT.
if !utils.EnvVarExists(utils.RAY_GCS_RPC_SERVER_RECONNECT_TIMEOUT_S, container.Env) && rayNodeType == rayv1.WorkerNode {
// If GCS FT is enabled and RAY_GCS_RPC_SERVER_RECONNECT_TIMEOUT_S is not set, set the worker's
Expand Down
Loading