[Chore] Remove an unused variable in volcano scheduler #4223
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: wei-chenglai <[email protected]>
seanlaii
requested review from
MortalHappiness,
andrewsykim,
kevin85421 and
rueian
as code owners
Contributor
Author
|
Hi @win5923 @Future-Outlier , please help take a look when you have a chance. This is just a small nit PR. Thanks! |
win5923
approved these changes
Nov 22, 2025
Collaborator
win5923
left a comment
win5923
left a comment
There was a problem hiding this comment.
Thanks, I forgot to remove in #3972 (comment).
Future-Outlier
approved these changes
Nov 22, 2025
cchung100m
approved these changes
Nov 23, 2025
Contributor
cchung100m
left a comment
cchung100m
left a comment
There was a problem hiding this comment.
LGTM, thanks to @seanlaii 😄
Contributor
Author
|
Hi @rueian could you help merge the PR? Thank you all! |
400Ping
approved these changes
Nov 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
Remove an unused variable and change if/else to switch to improve readability.
Related issue number
Checks