Skip to content

[RayService][e2e] Fix misplaced max_ongoing_requests in incremental-upgrade serveConfigV2 #5107

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
andrewsykim merged 1 commit into from
Aug 10, 2026
Merged

[RayService][e2e] Fix misplaced max_ongoing_requests in incremental-upgrade serveConfigV2 #5107

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ray-operator/test/e2eincrementalupgrade/constant.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -110,11 +110,11 @@ const highRPSServeConfigV2 serveConfigV2 = `applications:
working_dir: "https://github.com/ray-project/serve_config_examples/archive/530e247ca195530b71b92d7e708048a1bdc02583.zip"
deployments:
- name: SimpleDeployment
max_ongoing_requests: 6

@andrewsykim andrewsykim Aug 10, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's kind of weird that this doesn't cause an error or some condition in the RayService status. As a follow-up we should consider doing some validation agains the RayService configs and raising an error earlier.

@justinyeh1995 justinyeh1995 Aug 10, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed. I'll look into this first, then file a follow-up issue to track it. Thanks for the suggestion!

autoscaling_config:
min_replicas: 1
max_replicas: 2
target_ongoing_requests: 2
max_ongoing_requests: 6
upscale_delay_s: 0.5
ray_actor_options:
num_cpus: 2
Expand Down
Loading