[History Server] create helper to extract similar pattern for session node listing - #5113
Open
markwu7 wants to merge 3 commits into
Open
[History Server] create helper to extract similar pattern for session node listing#5113markwu7 wants to merge 3 commits into
markwu7 wants to merge 3 commits into
Conversation
Signed-off-by: Mark <markhww.jobs@gmail.com>
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes using default effort and found 1 potential issue.
Reviewed by Cursor Bugbot for commit 87a2d93. Configure here.
Signed-off-by: Mark <markhww.jobs@gmail.com>
win5923
reviewed
Aug 10, 2026
Signed-off-by: Mark <markhww.jobs@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
Since several code with duplicated pattern to list node directories under a session. Extract
storage.ListSessionNodeDirsto de-duplicate the repeated session node-directory listing pattern.Related issue number
Part of #5065
Follow-up to #4918
Labels
doc-updates-requiredlabel.breaking-changelabel.Checks
Manual test instructions