Skip to content

fix(grafana): move autoscaler node count into collapsed section - #5115

Open
EcchaBansalAgrawal wants to merge 1 commit into
ray-project:masterfrom
EcchaBansalAgrawal:fix-grafana-node-count
Open

fix(grafana): move autoscaler node count into collapsed section#5115
EcchaBansalAgrawal wants to merge 1 commit into
ray-project:masterfrom
EcchaBansalAgrawal:fix-grafana-node-count

Conversation

@EcchaBansalAgrawal

Copy link
Copy Markdown

Why are these changes needed?

The default Grafana dashboard displays a "Node Count" panel that depends on autoscaler metrics. When autoscaling is disabled, these metrics are unavailable and the panel appears empty, which can be confusing to users.

This change moves the autoscaler-dependent "Node Count" panel into a collapsed "Autoscaling" section. This keeps the default dashboard clean while preserving the existing Node Count panel configuration and queries.

Related issue number

Closes #5026

Labels

  • If this PR has user-facing changes that require documentation updates at release time, I have added the doc-updates-required label.
  • If this PR contains breaking changes, I have added the breaking-change label.

Checks

  • I've made sure the tests are passing.
  • Testing Strategy
    • Unit tests
    • Manual tests
    • This PR is not tested :(

Manual test instructions

  1. Validated the modified Grafana dashboard JSON successfully.
  2. Verified that the "Node Count" panel is no longer a top-level dashboard panel.
  3. Verified that the "Node Count" panel is present inside the collapsed "Autoscaling" section.
  4. Ran 'git diff --check' successfully with no errors.
  5. Verified that the final Git diff contains only the intended dashboard change.
  6. Verified that the existing Node Count panel configuration and queries were preserved.

A live Grafana UI test was not performed.

@cursor cursor Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes using default effort and found 1 potential issue.

Fix All in Cursor

Reviewed by Cursor Bugbot for commit 1393e98. Configure here.

"h": 1,
"w": 24,
"x": 0,
"y": 1

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overlapping dashboard panel positions

Medium Severity

The new collapsed Autoscaling row is placed at y: 1, but Cluster Utilization still uses y: 1 as well, so the two overlap in the grid. Later panels were not shifted down either, and Cluster Utilization remains at x: 12, leaving an empty left half where Node Count used to sit. This can scramble the Overview layout in Grafana.

Additional Locations (1)
Fix in Cursor Fix in Web

Reviewed by Cursor Bugbot for commit 1393e98. Configure here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Feature request] Default grafana dashboard shows confusing "node count" panel

1 participant