fix(grafana): move autoscaler node count into collapsed section - #5115
Open
EcchaBansalAgrawal wants to merge 1 commit into
Open
fix(grafana): move autoscaler node count into collapsed section#5115EcchaBansalAgrawal wants to merge 1 commit into
EcchaBansalAgrawal wants to merge 1 commit into
Conversation
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes using default effort and found 1 potential issue.
Reviewed by Cursor Bugbot for commit 1393e98. Configure here.
| "h": 1, | ||
| "w": 24, | ||
| "x": 0, | ||
| "y": 1 |
There was a problem hiding this comment.
Overlapping dashboard panel positions
Medium Severity
The new collapsed Autoscaling row is placed at y: 1, but Cluster Utilization still uses y: 1 as well, so the two overlap in the grid. Later panels were not shifted down either, and Cluster Utilization remains at x: 12, leaving an empty left half where Node Count used to sit. This can scramble the Overview layout in Grafana.
Additional Locations (1)
Reviewed by Cursor Bugbot for commit 1393e98. Configure here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Why are these changes needed?
The default Grafana dashboard displays a "Node Count" panel that depends on autoscaler metrics. When autoscaling is disabled, these metrics are unavailable and the panel appears empty, which can be confusing to users.
This change moves the autoscaler-dependent "Node Count" panel into a collapsed "Autoscaling" section. This keeps the default dashboard clean while preserving the existing Node Count panel configuration and queries.
Related issue number
Closes #5026
Labels
doc-updates-requiredlabel.breaking-changelabel.Checks
Manual test instructions
A live Grafana UI test was not performed.