Skip to content

[history server][CI] fix broken test build on master - #5116

Merged
andrewsykim merged 1 commit into
ray-project:masterfrom
win5923:fix-historyserver-test
Aug 11, 2026
Merged

[history server][CI] fix broken test build on master#5116
andrewsykim merged 1 commit into
ray-project:masterfrom
win5923:fix-historyserver-test

Conversation

@win5923

@win5923 win5923 commented Aug 10, 2026

Copy link
Copy Markdown
Member

Why are these changes needed?

PR #4918 and PR #4960 were developed in parallell, and #4960 was merged without rebasing onto the latest master branch. As a result, go vet now fails with the following error:

❯ go vet ./...

# github.com/ray-project/kuberay/historyserver/pkg/historyserver
# [github.com/ray-project/kuberay/historyserver/pkg/historyserver]
vet: pkg/historyserver/byte_cache_integration_test.go:34:31: undefined: utils.ClusterKey

Change

Update both test files to the current API:

  • byte_cache_integration_test.go: seed clusters through a mockStorageReader plus a fake ClientManager instead of clustersMap, and request /enter_cluster/{ns}/raycluster/{name}/{session}.
  • enter_cluster_test.go: pass DefaultSessionCacheMaxBytes to the five remaining NewSessionLoader calls.

Related issue number

Labels

  • If this PR has user-facing changes that require documentation updates at release time, I have added the doc-updates-required label.
  • If this PR contains breaking changes, I have added the breaking-change label.

Checks

  • I've made sure the tests are passing.
  • Testing Strategy
    • Unit tests
    • Manual tests
    • This PR is not tested :(

Manual test instructions

Signed-off-by: win5923 <ken89@kimo.com>
@win5923 win5923 changed the title [history server] fix broken test build on master [history server][CI] fix broken test build on master Aug 10, 2026
@CheyuWu
CheyuWu self-requested a review August 10, 2026 16:22
@win5923

win5923 commented Aug 10, 2026

Copy link
Copy Markdown
Member Author

cc @JiangJiaWei1103 and @chiayi to take a look when you have time. Thanks!

clustersMap: make(map[utils.ClusterKey][]utils.ClusterInfo),
reader: &mockStorageReader{
clusters: []utils.ClusterInfo{
{Namespace: ns, Name: name, SessionName: session, OwnerKind: "rayjob", OwnerName: "job-bc"},

@CheyuWu CheyuWu Aug 10, 2026

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: suggestion

Suggested change
{Namespace: ns, Name: name, SessionName: session, OwnerKind: "rayjob", OwnerName: "job-bc"},
{Namespace: ns, Name: name, SessionName: session, OwnerKind: utils.RayJobKind", OwnerName: "job-bc"},

@CheyuWu CheyuWu left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall, LGTM

@chiayi chiayi left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@andrewsykim
andrewsykim merged commit b663dc3 into ray-project:master Aug 11, 2026
33 checks passed
@win5923
win5923 deleted the fix-historyserver-test branch August 11, 2026 02:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants