[history server][CI] fix broken test build on master - #5116
Merged
Conversation
Signed-off-by: win5923 <ken89@kimo.com>
4 tasks
CheyuWu
self-requested a review
August 10, 2026 16:22
6 tasks
Member
Author
|
cc @JiangJiaWei1103 and @chiayi to take a look when you have time. Thanks! |
CheyuWu
reviewed
Aug 10, 2026
| clustersMap: make(map[utils.ClusterKey][]utils.ClusterInfo), | ||
| reader: &mockStorageReader{ | ||
| clusters: []utils.ClusterInfo{ | ||
| {Namespace: ns, Name: name, SessionName: session, OwnerKind: "rayjob", OwnerName: "job-bc"}, |
Collaborator
There was a problem hiding this comment.
nit: suggestion
Suggested change
| {Namespace: ns, Name: name, SessionName: session, OwnerKind: "rayjob", OwnerName: "job-bc"}, | |
| {Namespace: ns, Name: name, SessionName: session, OwnerKind: utils.RayJobKind", OwnerName: "job-bc"}, |
andrewsykim
approved these changes
Aug 10, 2026
6 tasks
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
PR #4918 and PR #4960 were developed in parallell, and #4960 was merged without rebasing onto the latest master branch. As a result, go vet now fails with the following error:
Change
Update both test files to the current API:
byte_cache_integration_test.go: seed clusters through amockStorageReaderplus a fakeClientManagerinstead ofclustersMap, and request/enter_cluster/{ns}/raycluster/{name}/{session}.enter_cluster_test.go: passDefaultSessionCacheMaxBytesto the five remainingNewSessionLoadercalls.Related issue number
Labels
doc-updates-requiredlabel.breaking-changelabel.Checks
Manual test instructions