[RayService][Test] Stop propagating proc.returncode in locust_runner.py - #5117
Open
justinyeh1995 wants to merge 1 commit into
Open
[RayService][Test] Stop propagating proc.returncode in locust_runner.py#5117justinyeh1995 wants to merge 1 commit into
justinyeh1995 wants to merge 1 commit into
Conversation
…#5109 Signed-off-by: justinyeh1995 <justinyeh1995@gmail.com>
1 task
win5923
approved these changes
Aug 11, 2026
win5923
left a comment
win5923
left a comment
Member
There was a problem hiding this comment.
Thanks for the detailed explanation!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
Per the conclusion in #5109, we stop the propagation of proc.returncode in locust_runner.py, because a race between gevent's greenlet scheduling and SIGINT delivery can cause the Locust master to exit with code 2 even when the run itself succeeded with no failed requests. Propagating exit code 2 today fails the e2e test despite the run being correct.
Related issue number
Related to #5109 & #5098
Labels
doc-updates-requiredlabel.breaking-changelabel.Checks
Manual test instructions
Ran the experiment in commits db7b78d & 8acb8c2: 0/50 runs failed.