Skip to content

[data] Adding in another kwargs#51068

Merged
aslonnie merged 1 commit intoray-project:masterfrom
omatthew98:mowen/add-second-kwargs-for-extension-type
Mar 4, 2025
Merged

[data] Adding in another kwargs#51068
aslonnie merged 1 commit intoray-project:masterfrom
omatthew98:mowen/add-second-kwargs-for-extension-type

Conversation

@omatthew98
Copy link
Contributor

@omatthew98 omatthew98 commented Mar 4, 2025

Why are these changes needed?

Followup to #51041, needed to add kwargs in a second method.

Related issue number

Checks

  • I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
    • I've added any new APIs to the API Reference. For example, if I added a
      method in Tune, I've added it in doc/source/tune/api/ under the
      corresponding .rst file.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

@omatthew98
adding in another kwargs
f06c431 
Signed-off-by: Matthew Owen <mowen@anyscale.com>
@omatthew98 omatthew98 requested review from aslonnie and raulchen March 4, 2025 20:09
@omatthew98 omatthew98 added the go add ONLY when ready to merge, run all tests label Mar 4, 2025
@aslonnie aslonnie merged commit 6cf3c72 into ray-project:master Mar 4, 2025
5 checks passed
abrarsheikh pushed a commit that referenced this pull request Mar 8, 2025
@omatthew98 @abrarsheikh
[data] Adding in another kwargs (#51068)
e564228 
Followup to #51041, needed to add kwargs in a second method.

Signed-off-by: Matthew Owen <mowen@anyscale.com>
Signed-off-by: Abrar Sheikh <abrar@anyscale.com>
park12sj pushed a commit to park12sj/ray that referenced this pull request Mar 18, 2025
@omatthew98 @park12sj
[data] Adding in another kwargs (ray-project#51068)
4220783 
Followup to ray-project#51041, needed to add kwargs in a second method.

Signed-off-by: Matthew Owen <mowen@anyscale.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@raulchen raulchen raulchen approved these changes

@aslonnie aslonnie aslonnie approved these changes

Assignees

No one assigned

Labels

community-backlog go add ONLY when ready to merge, run all tests

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@omatthew98 @raulchen @aslonnie @hainesmichaelc