Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AMD new products 2025 q2 #51802

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

vickytsang
Copy link
Contributor

Why are these changes needed?

Adding new GPU products for MI3xx product line

Checks

  • I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
    • I've added any new APIs to the API Reference. For example, if I added a
      method in Tune, I've added it in doc/source/tune/api/ under the
      corresponding .rst file.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

@vickytsang
Copy link
Contributor Author

Unit test results

root@hpe-hq-08:/app/ray# python -m pytest -v -s python/ray/tests/accelerators/test_amd_gpu.py
============================================================= test session starts =============================================================
platform linux -- Python 3.12.9, pytest-7.3.2, pluggy-1.5.0 -- /opt/conda/envs/py_3.12/bin/python
cachedir: .pytest_cache
hypothesis profile 'default' -> database=DirectoryBasedExampleDatabase('/app/ray/.hypothesis/examples')
rootdir: /app/ray
configfile: pytest.ini
plugins: hypothesis-5.35.1, rerunfailures-14.0, flakefinder-1.1.0, xdist-3.3.1, cpp-2.3.0, xdoctest-1.1.0, typeguard-4.3.0
collected 5 items

python/ray/tests/accelerators/test_amd_gpu.py::test_visible_amd_gpu_ids Usage stats collection is enabled by default for nightly wheels. To disable this, run the following command: ray disable-usage-stats before starting Ray. See https://docs.ray.io/en/master/cluster/usage-stats.html for more details.
2025-03-28 23:04:46,902 INFO worker.py:1852 -- Started a local Ray instance.
PASSED
python/ray/tests/accelerators/test_amd_gpu.py::test_visible_amd_gpu_type Usage stats collection is enabled by default for nightly wheels. To disable this, run the following command: ray disable-usage-stats before starting Ray. See https://docs.ray.io/en/master/cluster/usage-stats.html for more details.
2025-03-28 23:04:52,082 INFO worker.py:1852 -- Started a local Ray instance.
PASSED
python/ray/tests/accelerators/test_amd_gpu.py::test_visible_amd_gpu_type_bad_device_id Usage stats collection is enabled by default for nightly wheels. To disable this, run the following command: ray disable-usage-stats before starting Ray. See https://docs.ray.io/en/master/cluster/usage-stats.html for more details.
2025-03-28 23:04:57,418 INFO worker.py:1852 -- Started a local Ray instance.
PASSED
python/ray/tests/accelerators/test_amd_gpu.py::test_get_current_process_visible_accelerator_ids PASSED
python/ray/tests/accelerators/test_amd_gpu.py::test_set_current_process_visible_accelerator_ids PASSED

============================================================= 5 passed in 15.70s ==============================================================

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant