[rlsw] c++ support #5291
Merged
[rlsw] c++ support #5291
+77
−64
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Comment on lines
+2592
to
+2600
| /* Pixel color computation */ \ | ||
| float wRcp = 1.0f/w; \ | ||
| float srcColor[4] = { \ | ||
| color[0]*wRcp, \ | ||
| color[1]*wRcp, \ | ||
| color[2]*wRcp, \ | ||
| color[3]*wRcp \ | ||
| }; \ | ||
| \ |
There was a problem hiding this comment.
Because the goto; it is illegal to bypass the initialization of a local variable in cpp. Even if it's not used.
raysan5
reviewed
Oct 23, 2025
|
@alexgb0 Added a review for some minor formatting changes |
|
Sorry, didn't pay attention |
|
@alexgb0 Looks good, merging. Thanks for the review! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes
rlswto be able to compile in C/C++.Most of the problems comes from casting
void*to something else, in the macros I had to move some variables declaration too.Tested in win10 MSVC