migrate(sdk): projects page api #1224
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Pull Request Test Coverage Report for Build 18971187933Details
💛 - Coveralls |
paanSinghCoder
changed the title
rohilsurana
reviewed
Oct 31, 2025
| select: d => ({ | ||
| groups: d?.groups ?? [], | ||
| groupRoles: (d?.rolePairs ?? []).reduce((acc: Record<string, ProtoRole[]>, gr: ProjectGroupRolePair) => { | ||
| const key = gr.groupId ?? gr.group_id; |
There was a problem hiding this comment.
I am getting a little worries how we are going to get rid of these from codebase, once we are done with migration.
Should we add a TODO?
There was a problem hiding this comment.
Yes, these are everywhere. Won't be hard find later.
rohilsurana
reviewed
Oct 31, 2025
| } from '~/src'; | ||
|
|
||
| interface useOrganizationProjectsProps { | ||
| showInhreitedProjects?: boolean; |
There was a problem hiding this comment.
old typo here, can you take care of this?
There was a problem hiding this comment.
Done. Checked for usage as well.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.