Tensorflow 2.0 compatibility #71
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The tests pass with this set of dependencies.
Running the upgrade script (which resulted in no changes), updating dependencies, and explicitly installing keras_applications was enough.
- makes setup.py consistent with Pipfile - increments version number - remove travis config, since travis-ci.org is going away and builds were already erroring - verify that all sample code in README works
|
Thanks for your contribution! I will fix the Travis setup and tests soon then we can merge this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks for this library! I needed TF 2.0 compatibility, so I thought I'd offer it back upstream.
This didn't require changes to your VGGFace code. I added a Pipfile/Pipfile.lock for ease of installation, upgraded setup.py and the README accordingly, and bumped the version number. I also removed the travis config since the build is erroring and travis-ci.org is EOLing anyway -- making travis work again is outside of my scope.