-
Notifications
You must be signed in to change notification settings - Fork 133
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: fix eslint #471
chore: fix eslint #471
Conversation
WalkthroughThe changes in this pull request involve two main modifications. First, the Changes
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Outside diff range and nitpick comments (1)
package.json (1)
41-41
: LGTM! Good choice downgrading to ESLint v8.This is a sensible change as ESLint v9 is currently in alpha/beta. Using v8.57.1 (the latest stable version) ensures better stability and compatibility with the existing eslint plugins.
Consider adding an entry to your package.json's
engines
field to specify the minimum required Node.js version that's compatible with ESLint v8, although the current"node": ">=12.0"
should work fine as ESLint v8 supports Node.js 12+.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
⛔ Files ignored due to path filters (1)
package-lock.json
is excluded by!**/package-lock.json
📒 Files selected for processing (2)
package.json
(1 hunks)test/N3Writer-test.js
(0 hunks)
💤 Files with no reviewable changes (1)
- test/N3Writer-test.js
Summary by CodeRabbit
Bug Fixes
Writer
class to manage output stream issues.Tests
Writer
class, validating serialization of triples and quads, and covering various edge cases and output formats.Chores
eslint
dependency version inpackage.json
.