-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: set up changesets for version and release automation #10
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I propose we also add changesets bot which adds a comment summarising a PR's new changelog files
"@rdfjs/types": major | ||
--- | ||
|
||
First release, migrated from @types/rdf-js |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One nice thing is that change entries are version controlled and PR-reviewed
Once we're ready for a release, they will be removed and inserted into the CHANGELOG.md
by CI workflow release.yml
Before that happens, that same workflow will maintain a release PR similar to hypermedia-app/Alcaeus#221
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These files can be added manually, running npx changeset
, or by virtue of changeset bot's comment, which looks like hypermedia-app/shaperone#126 (comment)
publish: yarn release | ||
env: | ||
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} | ||
NPM_TOKEN: ${{ secrets.NPM_TOKEN }} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Need to add this as repo or Org secret
@@ -1,6 +1,6 @@ | |||
{ | |||
"name": "@rdfjs/types", | |||
"version": "2.0.0", | |||
"version": "0.0.0", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I pushed back to 0.0
since this package was never released.
As you see in .changesets/lemon-comics-knock.md
, this PR will cause a major bump, thus the next package would be 1.0
Going to merge this? If we agree, then let's add that NPM token and start publishing this. Would the also proceed with the Definitiely Typed deprecation and new proxy package cc @rubensworks |
@tpluscode @blake-regalia I've given you both access to the
I would suggest waiting with deprecation a bit, until we are certain enough that things are stable (perhaps once we have updated a couple of packages to these new typings). |
@tpluscode i updated repo team permissions so you should now be able to merge this PR |
Thanks. Let me add the bot then Do we have an NPM org for |
Re #3, here's my proposal for using Atlassian changesets to automate changelog and releases