Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: set up changesets for version and release automation #10

Merged
merged 2 commits into from
May 27, 2021

Conversation

tpluscode
Copy link
Contributor

Re #3, here's my proposal for using Atlassian changesets to automate changelog and releases

Copy link
Contributor Author

@tpluscode tpluscode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I propose we also add changesets bot which adds a comment summarising a PR's new changelog files

Comment on lines +2 to +5
"@rdfjs/types": major
---

First release, migrated from @types/rdf-js
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One nice thing is that change entries are version controlled and PR-reviewed

Once we're ready for a release, they will be removed and inserted into the CHANGELOG.md by CI workflow release.yml

Before that happens, that same workflow will maintain a release PR similar to hypermedia-app/Alcaeus#221

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These files can be added manually, running npx changeset, or by virtue of changeset bot's comment, which looks like hypermedia-app/shaperone#126 (comment)

publish: yarn release
env:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
NPM_TOKEN: ${{ secrets.NPM_TOKEN }}
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to add this as repo or Org secret

@@ -1,6 +1,6 @@
{
"name": "@rdfjs/types",
"version": "2.0.0",
"version": "0.0.0",
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I pushed back to 0.0 since this package was never released.

As you see in .changesets/lemon-comics-knock.md, this PR will cause a major bump, thus the next package would be 1.0

@blake-regalia blake-regalia self-requested a review May 15, 2021 18:18
@tpluscode
Copy link
Contributor Author

Going to merge this? If we agree, then let's add that NPM token and start publishing this. Would the also proceed with the Definitiely Typed deprecation and new proxy package

cc @rubensworks

@rubensworks
Copy link
Member

rubensworks commented May 19, 2021

@tpluscode @blake-regalia I've given you both access to the rdf-js package. Feel free to configure an npm token for publishing to it.

Would the also proceed with the Definitiely Typed deprecation and new proxy package

I would suggest waiting with deprecation a bit, until we are certain enough that things are stable (perhaps once we have updated a couple of packages to these new typings).

@blake-regalia
Copy link
Contributor

@tpluscode i updated repo team permissions so you should now be able to merge this PR

@tpluscode
Copy link
Contributor Author

Thanks. Let me add the bot then

Do we have an NPM org for @rdfjs where to create a token?

@tpluscode tpluscode merged commit 2a3a3c2 into rdfjs:master May 27, 2021
@tpluscode tpluscode deleted the changesets branch May 27, 2021 13:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants