-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added type to export #36
base: master
Are you sure you want to change the base?
Conversation
🦋 Changeset detectedLatest commit: 2eafb73 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Hm, having used vite myself, I have not experience such an issue. Could you share your project or a minimal reproduction so that I can understand what's happening here? |
Sure I will try to reproduce the issue. |
Oh, I came back here looking at some other PRs and I think I realise that your problem is probably with TS module resolution. I think a more robust improvement would be to add |
Cool! Sorry haven't come around it to create a simple way to reproduce my issue. I might be able to spend some time to try your solution with the next upgrade cycle. |
So, expanding on my comment above, I expect you should be able to reproduce when you set |
Hi hi so I was able to create a minimal reproduction: Switching moduleResolution to:
|
Moving from Webpack 4 to Vite 4.
When we build our application we get the error that Vite:
I was able to solve the issue locally by editing the
index.d.ts
from this package.I hope with this change to make rdfjs accessible for Vite users as well.