Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove using namespace std from Python #1473

Draft
wants to merge 2 commits into
base: production
Choose a base branch
from
Draft

Remove using namespace std from Python #1473

wants to merge 2 commits into from

Conversation

cielavenir
Copy link
Collaborator

openrave_int.h is a public header of python binding, so using namespace std; should not be used.

@cielavenir cielavenir marked this pull request as draft November 26, 2024 12:00
@cielavenir
Copy link
Collaborator Author

controllercommon etc's python bindings replies on using namespace std; already. removing it has too much impact.

@cielavenir
Copy link
Collaborator Author

@felixvd @hemangandhi could you fix mujin (controllercommon etc) compilation with this MR?

@hemangandhi
Copy link
Collaborator

https://tiny.mujin.co.jp/or-1473-internal-test -- the internal changes needed for this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@felixvd felixvd Awaiting requested review from felixvd

@hemangandhi hemangandhi Awaiting requested review from hemangandhi

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cielavenir @hemangandhi