Skip to content

fix: ie scroller not working #469

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix: ie scroller not working #469

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 11 additions & 3 deletions src/utils/commonUtil.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,6 +44,14 @@
return option.isLeaf ?? !option[fieldNames.children]?.length;
}

function scrollTo (el, distance) {
if (typeof el.scrollTo !== 'function') {
el.scrollTop = distance;

Check warning on line 49 in src/utils/commonUtil.ts

View check run for this annotation

Codecov / codecov/patch

src/utils/commonUtil.ts#L49 

Added line #L49 was not covered by tests
} else {
el.scrollTo({ top: distance });
}
}

export function scrollIntoParentView(element: HTMLElement) {
const parent = element.parentElement;
if (!parent) {
Expand All @@ -52,9 +60,9 @@

const elementToParent = element.offsetTop - parent.offsetTop; // offsetParent may not be parent.
if (elementToParent - parent.scrollTop < 0) {
parent.scrollTo({ top: elementToParent });
scrollTo(parent, elementToParent);
} else if (elementToParent + element.offsetHeight - parent.scrollTop > parent.offsetHeight) {
parent.scrollTo({ top: elementToParent + element.offsetHeight - parent.offsetHeight });
scrollTo(parent, elementToParent + element.offsetHeight - parent.offsetHeight);
}
}

Expand All @@ -76,4 +84,4 @@
}

return (value.length === 0 ? [] : [value]).map(val => (Array.isArray(val) ? val : [val]));
}
}