Skip to content

Add an unset option to the collapse active key #180

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Add an unset option to the collapse active key #180

wants to merge 3 commits into from

Conversation

Ahmed-Sarkawt
Copy link

Having an unset option to provide easier customization to the collapse

Having an unset option to provide easier customization to the collapse
@vercel
Copy link

vercel bot commented Nov 30, 2020

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/react-component/collapse/6qe4in9iw
✅ Preview: https://collapse-git-patch-1.react-component.vercel.app

@codecov
Copy link

codecov bot commented Nov 30, 2020

Codecov Report

Attention: Patch coverage is 66.66667% with 1 line in your changes missing coverage. Please review.

Project coverage is 98.13%. Comparing base (ea1ab91) to head (94b6195).
Report is 90 commits behind head on master.

Files with missing lines Patch % Lines
src/Collapse.tsx 66.66% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #180      +/-   ##
==========================================
- Coverage   99.04%   98.13%   -0.92%     
==========================================
  Files           4        4              
  Lines         105      107       +2     
  Branches       33       34       +1     
==========================================
+ Hits          104      105       +1     
- Misses          1        2       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Update the ternary operator to if statement.
@Ahmed-Sarkawt
Copy link
Author

Having an unset option to the activeKey prop in order to make the component easier to handle

@lgtm-com
Copy link
Contributor

lgtm-com bot commented Nov 30, 2020

This pull request introduces 12 alerts when merging 06c92a3 into ea1ab91 - view on LGTM.com

new alerts:

  • 12 for Syntax error

Copy link
Author

@Ahmed-Sarkawt Ahmed-Sarkawt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Update the condition of the if statement in Collapse component

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant