-
-
Notifications
You must be signed in to change notification settings - Fork 190
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Support document.activeElement #360
feat: Support document.activeElement #360
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Codecov Report
@@ Coverage Diff @@
## master #360 +/- ##
==========================================
+ Coverage 98.12% 98.14% +0.02%
==========================================
Files 7 7
Lines 160 162 +2
Branches 50 50
==========================================
+ Hits 157 159 +2
Misses 2 2
Partials 1 1
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Is this update ever going to get redeployed? Seems like it will fix an issue that will greatly improve the a11y of antD. It has been sitting idle for almost 1 year. |
Conflicting |
What does conflicting even mean? There are merge conflicts? |
Rebase please |
@AnathanPham you were the one who originally made this change, I am not sure how to fix the conflict, is this something that you can do? Maybe get this fix pushed? |
Because this has been sitting stale for a while I have forked the fix by @AnathanPham and fixed issues with the index.spec.tsx. You can see the new PR here. #393 |
支持
document.activeElement
获取到dialog
组件的内容,而不是一个空的div。ant-design/ant-design#40380
使用一个div包裹
dialog
组件的内容,并使div聚焦,从而使div包含内容,而不是一个空的div。