Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(onChange): specify event may triggered with null #380

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

chalkpe
Copy link

@chalkpe chalkpe commented Nov 19, 2021

onChange is triggered with null sometimes, but type of value is just ValueType (string | number) for now.
However making this change is likely going to be a breaking change; it's more confusing null is given without any notice.

references

...
expect(onChange).toHaveBeenCalledWith(null);
...

@vercel
Copy link

vercel bot commented Nov 19, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/react-component/input-number/3npR9wzGX31HJtD9rgMbaxWaQsAE
✅ Preview: Failed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants