Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature/accessible-pages #207

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

lauriskuznecovs
Copy link

Introducing prop - focusOnListItem which enable/disable focus for <li>.
Currently it is enable by default, but there is many accessibility cases when focus is needed for child element (link or button).

This feature will make accessible page links by adding aria-current="page" and add visually hidden text inside link - "Page", so screen readers will pronounce "Page 1" instead of just "1".

Pagination accessibility best practices:
https://a11y-style-guide.com/style-guide/section-navigation.html#kssref-navigation-pagination

…li>. Currently it is enable by default, but there is many accessibility cases when focus is needed for child element (link or button).
@vercel
Copy link

vercel bot commented Oct 3, 2019

This pull request is automatically deployed with Now.
To access deployments, click Details below or on the icon next to each push.

Latest deployment for this branch: https://rc-pagination-git-fork-lauriskuznecovs-feature-accessible-pages.react-component.now.sh

@coveralls
Copy link

coveralls commented Oct 3, 2019

Coverage Status

Coverage increased (+0.2%) to 89.344% when pulling 4236e22 on lauriskuznecovs:feature/accessible-pages into 9ae5aee on react-component:master.

@lauriskuznecovs
Copy link
Author

This is tweak is really needed if you need accessible pagination.
Issue: #200

@edmond-io
Copy link

This is extremely useful when we cater for accessibility and assistive touch on pagination. @afc163
Please consider to merge it asap.

@afc163
Copy link
Member

afc163 commented Aug 4, 2020

conflict a lot

@brunoMaurice
Copy link

Little up this MR is very great improvement for accessibility

@lauriskuznecovs
Copy link
Author

Little up this MR is very great improvement for accessibility

I will try to find the time to resolve conflicts at some time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants