feat: Add Marathi language support #658

divyeshagrawal · 2025-09-26T02:13:33Z

Summary by CodeRabbit

新功能
- 新增马拉地语（印度，mr-IN）分页本地化，涵盖“每页条数”“跳转”“确认”“页”“上一页/下一页”“前进/后退5页”“前进/后退3页”“页面大小”等文案。
- 选择 mr-IN 语言环境时，分页控件将自动显示为马拉地语，提升本地用户的可读性与可用性。

vercel · 2025-09-26T02:13:38Z

The latest updates on your projects. Learn more about Vercel for GitHub.

Project	Deployment	Preview	Comments	Updated (UTC)
pagination	Ready	Preview	Comment	Sep 26, 2025 2:34am

coderabbitai · 2025-09-26T02:13:41Z

Note

Other AI code review bot(s) detected

CodeRabbit has detected other AI code review bot(s) in this pull request and will avoid duplicating their findings in the review comments. This may lead to a less comprehensive review.

Walkthrough

新增 src/locale/mr_IN.ts，定义并默认导出一个符合 PaginationLocale 类型的马拉地语（印度）分页本地化映射，包含 items_per_page、jump_to、jump_to_confirm、page、prev_page、next_page、prev_5、next_5、prev_3、next_3、page_size 等键，均为静态文案映射。

Changes

Cohort / File(s)	Change Summary
Locale: Marathi (India) `src/locale/mr_IN.ts`	新增马拉地语（印度）分页本地化常量，类型为 `PaginationLocale`，默认导出；仅包含静态字符串映射，无运行时逻辑。

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Possibly related PRs

feat:add telugu language support #656 — 添加了另一个语言的本地化模块（不同语言但相同目录与导出结构），在实现方式上高度相关。

Poem

我是小兔来报喜，
新添马拉地语一笔，
分页文案静静置，
前后跳页皆分明，
草丛里笑着说：本地化到齐 🐇✨

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title Check	✅ Passed	该标题简洁明了地说明了此次提交的主要修改内容——为项目添加马拉地语支持，能够让团队成员一目了然地了解变更目的。
Docstring Coverage	✅ Passed	No functions found in the changes. Docstring coverage check skipped.

✨ Finishing touches

📝 Generate Docstrings

🧪 Generate unit tests

Create PR with unit tests
Post copyable unit tests in a comment

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between ae50fd3 and f91ce05.

📒 Files selected for processing (1)

src/locale/mr_IN.ts (1 hunks)

🔇 Additional comments (1)

src/locale/mr_IN.ts (1)

3-18: 本地化文案覆盖完整且措辞自然。

各个分页键都给出了准确的马拉地语翻译，jump_to 末尾空格兼顾了拼接可读性，改用 पुढील 也避免了性别不一致，整体实现稳妥。

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

gemini-code-assist · 2025-09-26T02:13:43Z

Summary of Changes

Hello @divyeshagrawal, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request significantly enhances the application's internationalization by integrating Marathi language support. It specifically targets the pagination component, ensuring that all related UI texts are available in Marathi, thereby improving the user experience for Marathi-speaking users. The change involves adding a new locale file with comprehensive translations for pagination options and navigation controls.

Highlights

New Language Support: Introduced support for the Marathi language (mr_IN) within the application's localization system.
Pagination Localization: Added a new locale file specifically for pagination, providing Marathi translations for various pagination elements such as 'items per page', 'jump to', 'previous/next page', and 'page size'.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	`/gemini review`	Performs a code review for the current pull request in its current state.
Pull Request Summary	`/gemini summary`	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	`/gemini help`	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

gemini-code-assist

Code Review

This pull request introduces Marathi language support by adding the mr_IN.ts locale file. The implementation is clean and follows the existing pattern for localization. I've identified a minor UI issue related to string formatting for a tooltip and have provided a suggestion for a fix within the new locale file.

gemini-code-assist · 2025-09-26T02:14:43Z

src/locale/mr_IN.ts

+const locale: PaginationLocale = {
+  // Options
+  items_per_page: '/ पृष्ठ',
+  jump_to: 'यावर जा',


The jump_to string is used in Pagination.tsx to create a title attribute. It's concatenated directly with page numbers, like ${locale.jump_to}${current}/${allPages}. This will result in a title attribute like यावर जा5/10 without a space between the text and the numbers.

To fix this and ensure proper spacing in the tooltip, please add a trailing space to the string. While the ideal fix would be in Pagination.tsx, adjusting the translation here is a good workaround.

Suggested change

jump_to: 'यावर जा',

jump_to: 'यावर जा ',

coderabbitai

Actionable comments posted: 1

📜 Review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between b8515b7 and ae50fd3.

📒 Files selected for processing (1)

src/locale/mr_IN.ts (1 hunks)

src/locale/mr_IN.ts

codecov · 2025-09-26T02:19:32Z

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 99.03%. Comparing base (b8515b7) to head (f91ce05).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files

@@           Coverage Diff           @@
##           master     #658   +/-   ##
=======================================
  Coverage   99.03%   99.03%           
=======================================
  Files           3        3           
  Lines         310      310           
  Branches      139      139           
=======================================
  Hits          307      307           
  Misses          3        3

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

yoyo837 · 2025-09-26T02:22:58Z

Please check the AI review.

yoyo837 · 2025-09-26T02:42:34Z

If you want to use this in antd@5, you need to merge the PR into the 5.x branch, otherwise you need to wait until antd@6 is released.

divyeshagrawal · 2025-09-26T02:48:08Z

If you want to use this in antd@5, you need to merge the PR into the 5.x branch, otherwise you need to wait until antd@6 is released.

I can wait till version 6

yoyo837 · 2025-09-26T02:50:32Z

I can wait till version 6

OK.

yoyo837 · 2025-09-26T03:23:40Z

https://github.com/react-component/pagination/releases/tag/%40rc-component%2Fpagination%401.1.2

yoyo837 · 2025-09-26T03:37:32Z

I think this link is for last week's release

Sorry, this one https://github.com/react-component/pagination/releases/tag/%40rc-component%2Fpagination%401.1.3

divyeshagrawal · 2025-09-26T03:43:09Z

@yoyo837 I noticed that the new @rc-pagination is not being used in the ant-design repository on master branch. Is there any other branch for ant-design 6 or do I need to update all the imports of rc-pagination to use this in ant-design repository?

yoyo837 · 2025-09-26T06:25:53Z

See #658 (comment)

The next branch of the antd repo is for v6 and this release should be updated in it.

yoyo837 · 2025-09-26T06:27:38Z

https://github.com/react-component/pagination/tree/5.x for antd@5 master/feature
https://github.com/react-component/pagination/tree/master for antd@6 next

divyeshagrawal · 2025-09-27T08:12:18Z

Hey @yoyo837, since you have context of the changes that I am performing. Can you please also check this PR?

react-component/picker#943

feat: Add Marathi language support

ae50fd3

vercel bot deployed to Preview September 26, 2025 02:14 View deployment

gemini-code-assist bot reviewed Sep 26, 2025

View reviewed changes

coderabbitai bot reviewed Sep 26, 2025

View reviewed changes

src/locale/mr_IN.ts Outdated Show resolved Hide resolved

feat: update translations

f91ce05

vercel bot deployed to Preview September 26, 2025 02:34 View deployment

yoyo837 merged commit 270ddcc into react-component:master Sep 26, 2025
9 checks passed

	jump_to: 'यावर जा',
	jump_to: 'यावर जा ',

Uh oh!

feat: Add Marathi language support #658

feat: Add Marathi language support #658

Uh oh!

Conversation

divyeshagrawal commented Sep 26, 2025 • edited by coderabbitai bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary by CodeRabbit

Uh oh!

vercel bot commented Sep 26, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

coderabbitai bot commented Sep 26, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Other AI code review bot(s) detected

Walkthrough

Changes

Estimated code review effort

Possibly related PRs

Poem

Pre-merge checks and finishing touches

Uh oh!

gemini-code-assist bot commented Sep 26, 2025

Summary of Changes

Highlights

Footnotes

Uh oh!

gemini-code-assist bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

gemini-code-assist bot Sep 26, 2025

Choose a reason for hiding this comment

Uh oh!

coderabbitai bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

codecov bot commented Sep 26, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

yoyo837 commented Sep 26, 2025

Uh oh!

yoyo837 commented Sep 26, 2025

Uh oh!

divyeshagrawal commented Sep 26, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

yoyo837 commented Sep 26, 2025

Uh oh!

Uh oh!

yoyo837 commented Sep 26, 2025

Uh oh!

yoyo837 commented Sep 26, 2025

Uh oh!

divyeshagrawal commented Sep 26, 2025

Uh oh!

yoyo837 commented Sep 26, 2025

Uh oh!

yoyo837 commented Sep 26, 2025

Uh oh!

divyeshagrawal commented Sep 27, 2025

Uh oh!

Uh oh!

divyeshagrawal commented Sep 26, 2025 •

edited by coderabbitai bot

Loading

vercel bot commented Sep 26, 2025 •

edited

Loading

coderabbitai bot commented Sep 26, 2025 •

edited

Loading

codecov bot commented Sep 26, 2025 •

edited

Loading

divyeshagrawal commented Sep 26, 2025 •

edited

Loading