chore: remove useless #48
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #48 +/- ##
==========================================
+ Coverage 97.91% 98.93% +1.01%
==========================================
Files 3 3
Lines 96 94 -2
Branches 19 17 -2
==========================================
- Hits 94 93 -1
+ Misses 2 1 -1
📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more |
|
为啥删掉这个？ |
有点久忘了。。。现在看起来这块逻辑跟InternalSegmentedOption内部的change事件有重复，实际上是多余的，会导致单测覆盖不到这块逻辑 |
|
@vagusX 看看这个 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.