-
-
Notifications
You must be signed in to change notification settings - Fork 226
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(deps): update RC component dependencies #514
Conversation
Walkthrough在 @rc-component/trigger 包的 package.json 文件中,对依赖项进行了调整。修改内容包括移除旧依赖(@babel/runtime、classnames、rc-motion、rc-resize-observer、rc-util)以及添加新依赖(@rc-component/motion、@rc-component/resize-observer、@rc-component/util)。此外,.gitignore 文件中新增了对 .vscode 的忽略条目。多个示例文件中的 Trigger 组件导入路径也进行了更新,反映了包结构的变化。整体更改主要集中在依赖项和导入路径的更新,无其他业务逻辑或流程相关修改。 Changes
Suggested reviewers
Poem
Warning There were issues while running some tools. Please review the errors and either fix the tool’s configuration or disable the tool if it’s a critical failure. 🔧 ESLint
tests/setup.jsOops! Something went wrong! :( ESLint: 8.57.1 ESLint couldn't find the plugin "eslint-plugin-react". (The package "eslint-plugin-react" was not found when loaded as a Node module from the directory "".) It's likely that the plugin isn't installed correctly. Try reinstalling by running the following:
The plugin "eslint-plugin-react" was referenced from the config file in ".eslintrc.js » /node_modules/.pnpm/@umijs[email protected][email protected]/node_modules/@umijs/fabric/dist/eslint.js". If you still can't figure out the problem, please stop by https://eslint.org/chat/help to chat with the team. ✨ Finishing Touches
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
New and removed dependencies detected. Learn more about Socket for GitHub ↗︎
🚮 Removed packages: npm/[email protected] |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #514 +/- ##
=======================================
Coverage 97.71% 97.71%
=======================================
Files 13 13
Lines 788 788
Branches 231 235 +4
=======================================
Hits 770 770
Misses 18 18 ☔ View full report in Codecov by Sentry. |
@@ -64,15 +64,14 @@ | |||
"typescript": "^5.1.6" | |||
}, | |||
"dependencies": { | |||
"@babel/runtime": "^7.23.2", | |||
"@rc-component/motion": "^1.1.4", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
依赖变了,代码里也要变的~
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (1)
tests/setup.js (1)
4-10
: ResizeObserver 模拟实现看起来不错!模拟实现包含了 ResizeObserver 所需的所有必要方法(observe、unobserve 和 disconnect),这对于测试环境来说是足够的。
不过建议添加一些注释来说明这个模拟实现的用途。
建议添加如下注释:
+// 为测试环境模拟 ResizeObserver 接口 +// 由于 jsdom 环境中不存在 ResizeObserver, +// 我们需要提供一个基础实现来避免测试报错 global.ResizeObserver = jest.fn(() => { return { observe() { }, unobserve() { }, disconnect() { }, }; });
Summary by CodeRabbit
.vscode
文件夹的忽略规则。