Skip to content

fix: add nullish in dynamicCSS.ts #455

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
+5 −3
Open

fix: add nullish in dynamicCSS.ts #455

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
5397b78
fix: addEventListenerWrap param target may be nullish
zerosrat May 29, 2023
94ba8af
Merge branch 'react-component:master' into master
zerosrat Jul 26, 2023
903dfe1
fix: add nullish in dynamicCSS.ts
zerosrat Jul 26, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions src/Dom/dynamicCSS.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@ function getOrder(prepend?: Prepend): AppendType {
*/
function findStyles(container: ContainerType) {
return Array.from(
(containerCache.get(container) || container).children,
(containerCache.get(container) || container)?.children ?? [],
).filter(node => node.tagName === 'STYLE') as HTMLStyleElement[];
}

Expand All @@ -66,7 +66,7 @@ export function injectCSS(css: string, option: Options = {}) {
styleNode.innerHTML = css;

const container = getContainer(option);
const { firstChild } = container;
const firstChild = container?.firstChild;

if (prepend) {
// If is queue `prepend`, it will prepend first style and then append rest style
Expand All @@ -85,7 +85,9 @@ export function injectCSS(css: string, option: Options = {}) {
}

// Use `insertBefore` as `prepend`
container.insertBefore(styleNode, firstChild);
if (firstChild) {
container.insertBefore(styleNode, firstChild);
}
} else {
container.appendChild(styleNode);
}
Expand Down