Repository navigation
Conversation
|
@Pareder is attempting to deploy a commit to the afc163's projects Team on Vercel. A member of the Team first needs to authorize it. |
|
No actionable comments were generated in the recent review. Walkthrough滚动条的触摸开始处理现在会检查事件是否可取消。滚动条容器设置 Changes滚动条触摸处理
Estimated code review effort: 2 (Simple) | ~10 minutes Change: Bug fix · Severity of issue fixed: Medium Suggested reviewers: Merge Risk:
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #396 +/- ##
=======================================
Coverage 97.90% 97.90%
=======================================
Files 20 20
Lines 906 908 +2
Branches 215 217 +2
=======================================
+ Hits 887 889 +2
Misses 19 19 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Closes #395
While a momentum scroll is running, the browser dispatches
touchstartwithcancelable: false. The scrollbar's track and thumbtouchstarthandlers calledpreventDefault()unconditionally, which logged an[Intervention]warning. Since that call was ignored, the page could also scroll during a thumb drag.touch-action: noneon the scrollbar container. It keeps the page from panning whether or not thetouchstartis cancelable.preventDefault()whene.cancelableis true.Tests: added cases for a non-cancelable
touchstarton the track and on the thumb (nopreventDefault, and the thumb drag still starts), plus a check for thetouch-actionstyle. They fail without the fix; the full suite passes.Follow-up to #394.
Summary by CodeRabbit