Remove children from props of ErrorMessage when using component
#87
Conversation
| exports[`ErrorMessage should render correctly with flat errors and as with component and render 1`] = ` | ||
| <DocumentFragment> | ||
| flat | ||
| </DocumentFragment> |
There was a problem hiding this comment.
This looks incorrect. According to the README, the as should take precedence, but that seems to only apply to elements provided in as, not components.
There was a problem hiding this comment.
@lanvs oh... you are right!
We need to fix this.
There was a problem hiding this comment.
Do you need me to try to work on it in this PR, or can that maybe be a separate effort?
There was a problem hiding this comment.
Let's merge this once 👍🏻
If you are willing to help, we would like you to create another PR 🙏🏻
There was a problem hiding this comment.
I'll see what I can do, but TBH I'm stretched a bit thin at the moment.
|
thanks for the PR 👍 |
|
Hi there, any word on this? @kotarella1110 are you able to take a look? Thanks! |
| exports[`ErrorMessage should render correctly with flat errors and as with component and render 1`] = ` | ||
| <DocumentFragment> | ||
| flat | ||
| </DocumentFragment> |
There was a problem hiding this comment.
@lanvs oh... you are right!
We need to fix this.
|
Thanks @IanVS and @kotarella1110 |
|
Thanks both of you. I've created #88 to track the |
I tried using
ErrorMessagein my own project with anascomponent that takeschildrenas a prop. Because of the way the typescript is set up, it forced me to also add children to theErrorMessage, even though it ends up getting replaced with the actual error message.The change here removes children from the props when using a component in
as.I also added a pair of tests for components, since those were missing. I think one snapshot is revealing that the behavior is different from what's specified in the README, but I didn't tackle that change here, it can be done in another PR if it is indeed a bug.