feat: adopt SceneDelegate#246
Open
artus9033 wants to merge 1 commit into
Open
Conversation
|
Good |
Member
|
This is quite invasive change to the template. Can it wait till beginning of September? cc @cipolleschi |
Contributor
|
that's tricky. This needs to land after we land react/react-native#53744. This PR is technically additive and not breaking. However, Apple will start rejecting apps that are not using the SceneDelegate at some point and app built with Xcode27 (that's going to exit beta in September) will crash at startup. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
This PR migrates to SceneDelegate to make React Native apps bootstrapped with the Community Template and built with Xcode 27+ run on iOS 27+. It is based on instructions from react/react-native-website#5176 (with exception of
devMenuConfigurationinSceneDelegate.swift, which is added in the template).This PR should be released after the following PR to React Native is released: react/react-native#53744
Changelog:
[IOS] Adopt UIScene lifecycle (migrate to SceneDelegate)
Test Plan:
CI green, working locally.