Skip to content

docs: Native Stack - animationTypeForReplace #1351

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

stanleyoos
Copy link
Contributor

@stanleyoos stanleyoos commented Aug 1, 2024

React Navigation, Native Stack, v7.x

  • added sample animationTypeForReplace videos
  • updated animationTypeForReplace default value to push link

@stanleyoos stanleyoos self-assigned this Aug 1, 2024
Copy link

netlify bot commented Aug 1, 2024

Deploy Preview for react-navigation-docs ready!

Name Link
🔨 Latest commit 442570c
🔍 Latest deploy log https://app.netlify.com/sites/react-navigation-docs/deploys/66aca11144b3d500084e95c4
😎 Deploy Preview https://deploy-preview-1351--react-navigation-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@stanleyoos stanleyoos marked this pull request as ready for review August 1, 2024 14:35
@stanleyoos stanleyoos changed the title chore: Added sample animationTypeForReplace videos - Native Stack chore: Native Stack doc's - animationTypeForReplace Aug 2, 2024
Copy link
Member

@kacperkapusciak kacperkapusciak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's like a ~3 seconds wait before the animation starts happening. Could you shrink that waiting time a bit? It's frustrating when you look at the video and nothing happens

Screen.Recording.2024-08-02.at.09.39.04.mov

Copy link
Member

@kacperkapusciak kacperkapusciak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me!

@stanleyoos stanleyoos merged commit d1393ff into main Aug 2, 2024
3 checks passed
@stanleyoos stanleyoos deleted the @stanleyoos/chore-docs-native-stack-animationTypeForReplace branch August 2, 2024 10:23
@stanleyoos stanleyoos changed the title chore: Native Stack doc's - animationTypeForReplace docs: Native Stack - animationTypeForReplace Aug 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants