Render InputGroup, ButtonGroup, and Radio as <fieldset> to improve controlling and accessibility
#466
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adamkudrna
requested review from
mbohal,
bedrich-schindler,
hubacekj and
dacerondrej
adamkudrna
force-pushed
the
feature/fieldset-layouts
branch
from
346ff72 to
8862361
Compare
mbohal
approved these changes
May 18, 2023
bedrich-schindler
approved these changes
May 19, 2023
dacerondrej
approved these changes
May 19, 2023
…ignment in horizontal layout
…prove controlling and accessibility `InputGroup` can be `disabled` now.⚠️ Pontential BC: The suffix of the ID of `Radio` label element changed from `__labelText` to `__label` (so all input groups use the same approach).
adamkudrna
force-pushed
the
feature/fieldset-layouts
branch
from
379d63a to
9b2518a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All input groups now use the
<fieldset>element.InputGroupcan bedisablednow.Radiolabel element changed from__labelTextto__label(so all input groups use the same approach).