fix: css padding rule in class 'div.relative.py-10' #12
Conversation
|
Someone is attempting to deploy a commit to the Serbyte Development Team on Vercel. A member of the Team first needs to authorize it. |
|
I see a lot of red circles here. If you could help me remove them, I would be very grateful! 😀 |
Austin1serb
left a comment
Austin1serb
left a comment
There was a problem hiding this comment.
👋 Thanks for the contribution — this looks solid overall.
One small change request: Instead of adding a new layout.css file, please move the div.relative.py-10 { padding: 0; } rule into examples/demo/src/app/global.css.
Reasoning:
This is a global layout tweak, not scoped to one layout.
Helps keep the demo clean and avoid unnecessary file bloat.
Once you move the rule and remove the layout.css import, this will be good to go. Appreciate the PR!
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
@Austin1serb Just letting You know You keep me hanging - You either accept the PR or reject it ❤️🔥 Best wishes 🤝 |
|
Thanks again for contributing 🙏 - but after reviewing the preview deployment, this unfortunately doesn’t resolve the original issue. I’m going to close this PR to keep the codebase clean. You’re welcome to open another one if you’d like to take another stab at it — feel free to reference the issue for clarity. Appreciate the effort regardless. Best wishes.
|
2 participants
Summary
"Closes #10"
Unnecessary css rule padding-top and padding-bottom set to 0px so that the UI will display correctly when scrolling
Type of Change
Checklist
pnpm test)pnpm lint && pnpm format)feat:,fix:, etc.)Notes for Reviewer
Made without tailwind manipulations, but with pure css fix